Mark temporal point info metadata as suffix metadata - #5345
Merged
Conversation
SMPaluri
approved these changes
Aug 28, 2026
Contributor
|
Thanks Xin, I think it could also just change is_suffix = 1 so that it is appended at the end. But what you have is fine. I meant to add an encoder cli to set is_suffix for all the metadata. |
xinzhao-apple
force-pushed
the
mr/avm-bugfix6
branch
from
August 28, 2026 22:23
f0726d1 to
9aaf180
Compare
xinzhao-apple
changed the title
Contributor
Author
Thanks Seethal for the review and approval, I've updated the PR to just is_suffix = 1. Much smaller change and the decoded output is identical. Agreed that an encoder CLI (in a separate commit) to set is_suffix for all metadata is the more systematic fix. |
Temporal point info is written after the coded frame OBU but was marked as prefix metadata (is_suffix == 0). The decoder treats a prefix metadata OBU that follows a coded frame as the start of the next frame unit, so --timing-info=model produced a stream that failed to decode with "Unspecified internal error" on a nonexistent trailing frame.
urvangjoshi
force-pushed
the
mr/avm-bugfix6
branch
from
August 28, 2026 23:24
9aaf180 to
fda6694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporal point info is prefix metadata (is_suffix == 0), but it was written after the tile group OBUs. The decoder treats a prefix metadata OBU that follows a coded frame as the start of the next frame unit, so --timing-info=model produced a stream that failed to decode with "Unspecified internal error" on a nonexistent trailing frame.
Fix (Encoder only): Set is_suffix = 1 to match where the OBU is written.